Philip Helger

Results 288 comments of Philip Helger

Agree, would be nicer, but that is kind of a bigger change. The current solution is a valid work around, and I will leave this suggestion open.

@guiguilechat please check if that (3.3.1-SNAPSHOT) looks reasonable to you, or if there further improvements that make sense. Thx again for your input.

Voila. The new exception hierarchy forced me to change the version to 3.4.0

@guiguilechat please review. Afterwards I can release

Thanks for your review @guiguilechat * I will not add a new package for exceptions, as this would be even a source incompatible change. This is something for a major...

Thanks, but that is not correct. Because for a class the ".java" suffix is appended. And that is already part of the existing `JResourceDirTest`: ```java @Test (expected = JClassAlreadyExistsException.class) public...

Okay, so I created a lot of additional consistency checks. See the `JResourceDirTest` - with filename, directory name and class names. Except for some edge cases where directories have a...

Thanks for testing. Basically accepted your proposal. Do you need more, or shall I start a release build?

Thanks for your effort. In general I prefer PRs since I'm using Windows without the fancy commandline tools ;-)

OK, PR was accepted. I tested if there were different rules for filenames and directories on Linux, but even a `mkdir "*"` worked so no need for separate rules. Do...