particle icon indicating copy to clipboard operation
particle copied to clipboard

Cannot GET .../00-protons-demo/index.html (links broken after fresh install)

Open ianlintner-wf opened this issue 6 years ago • 2 comments
trafficstars

Clicking on many links Under Patterns on Fresh install result in error of:

Full Message In Browser Window: "Cannot GET /app-node-pl/pl/patterns/00-protons-demo/index.html"

Steps to recreate:

npm create @phase2/particle particle cd particle npm start

open browser click through links

(node version 10.16)

ianlintner-wf avatar Sep 24 '19 19:09 ianlintner-wf

Hello! I have a few open issues/comments on open PR's upstream to the node-pattern-lab repo.

The issue is that you have to navigate manually to the demo/ folder and pick each pattern from there. Upstream, the node-pattern-lab team are tweaking how they "discover" sub-patterns within main folders like atoms, molecules, etc so at the moment no "View All" page is being generated for patterns that ONLY live in sub folder (ie demo/).

We'll get our node-pl libraries updated as soon as they are fixed upstream.

illepic avatar Sep 25 '19 18:09 illepic

That’s what I figured it’s in flux after I did a little digging based on the big version number upgrade commit.

Combined with the major dev work going on in the monorepo it all makes sense.

The last version prior to the upgrade still is working. Probably going to hold off on upgrading till the upstream stuff is stable.

Sent from my iPhone

On Sep 25, 2019, at 1:04 PM, Christopher Bloom [email protected] wrote:

Hello! I have a few open issues/comments on open PR's upstream to the node-pattern-lab repo.

The issue is that you have to navigate manually to the demo/ folder and pick each pattern from there. Upstream, the node-pattern-lab team are tweaking how they "discover" sub-patterns within main folders like atoms, molecules, etc so at the moment no "View All" page is being generated for patterns that ONLY live in sub folder (ie demo/).

We'll get our node-pl libraries updated as soon as they are fixed upstream.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

ianlintner-wf avatar Sep 26 '19 00:09 ianlintner-wf