particle icon indicating copy to clipboard operation
particle copied to clipboard

Update Pa11y Config for Node Pattern Lab 3

Open jryanconklin opened this issue 6 years ago • 2 comments
trafficstars

Issue

The default config for pa11y is no longer compatible with Node PL 3.

Analysis

See this PR on the update to resolve: https://github.com/pattern-lab/patternlab-node/pull/1035

const {
  patternPaths,
  navItems,
  // eslint-disable-next-line import/no-unresolved
} = require('../dist/app-node-pl/pl/styleguide/data/patternlab-data.cjs.js');

This PR should account for documenting how to fix as well as tracking the Pattern Lab PR above to see if it's merged. If merged, we don't need to patch Particle. Else, we should create the patch file per docs/patches.md

Confirmation

As a developer, I can run pa11y tests on my Particle.

jryanconklin avatar Aug 15 '19 02:08 jryanconklin

This fix should also add pa11y-ci back to the devDependencies section of package.json file, as it is missing at this time.

jhedstrom avatar Sep 23 '19 22:09 jhedstrom

@jhedstrom We don't turn on pally-ci by default on Particle. It's up to the project to enable it considering the size of the Chromium download.

jryanconklin avatar Sep 23 '19 23:09 jryanconklin