cargo-sync-readme icon indicating copy to clipboard operation
cargo-sync-readme copied to clipboard

Published 20 hours ago • verified publisher icon phaazon

Fix bug handling images with links.

Open orium opened this issue 4 years ago • 5 comments
trafficstars

I guess as one of the first users I would get one of the first bugs :slightly_smiling_face:

Before this commit links with images would get corrupted: the image would simply be removed.

This PR changes the link handling logic to not care about what's inside the text in a link and simply copy it verbatim from the source markdown, avoiding this and other similar problems were things are nested inside a link's text.

~Merge #53 before this, so I can add an integration test for this.~ ✓

orium avatar Jan 14 '21 20:01 orium

Rebased on master. Should be ready for review now.

orium avatar Jan 28 '21 18:01 orium

Is this getting merged? I am running into this issue as well. Thanks.

metabrain avatar May 08 '21 16:05 metabrain

@phaazon Can you take a look at this PR and PR #56 when you have some time please?

orium avatar May 13 '21 10:05 orium

Hi @phaazon. This project had been pretty low in activity in the last few months. Let me know if you no longer want to maintain it. I'm happy to fork the project, work on it, and maintain it if you no longer wish to do so.

orium avatar Sep 28 '21 14:09 orium

I've created my own project to create READMEs from rustdoc. It addresses the issue in this PR as well as PR #56 and other bugs: https://github.com/orium/cargo-rdme.

orium avatar Nov 16 '21 20:11 orium