pgvector-rust
pgvector-rust copied to clipboard
Update Cargo.toml
Bumps the dependency to at least 2.2.3 as per the advisory
(even though this crate may not be using the function mentioned in the advisory, it is better to bump it to ensure that there is no chance of other dependencies pulling it)
Hi @Dylan-DPC, thanks for the PR. From what I can tell (testing w/ rust_decimal, which incorporated this in 1.37.0):
- If an earlier version of Diesel is installed, this will pull in an earlier version of
pgvector - If a later version of Diesel is installed, there is no change in behavior
- If Diesel is not already installed, Cargo will pull in the latest version (no change in behavior)
Based on the above, it seems like this has a drawback without any benefit (but let me know if I missed something).
It looks like the benefit is dependent on how the dependency is specified in Cargo.toml.
rust_decimal = { version = "1", features = ["db-diesel2-postgres"] }
will pull in an earlier version of rust_decimal, while
rust_decimal = { version = "1.37", features = ["db-diesel2-postgres"] }
will upgrade diesel (or error if it can't be upgraded).
Closing this as it's been a while and there might be newer versions so i feel this is better if we done fresh.