sqlite_fdw icon indicating copy to clipboard operation
sqlite_fdw copied to clipboard

Published 20 hours ago • verified publisher icon pgspider

Cannot build for PG16r1

Open JamesInform opened this issue 2 years ago • 17 comments

I cannot build the compoent for PG16r1.

Are you planning to update the extension any time soon?

JamesInform avatar Sep 02 '23 13:09 JamesInform

@JamesInform , please show the main compilation problems by your opinion. How many problems there are?

mkgrgis avatar Sep 02 '23 17:09 mkgrgis

Hi!

image

JamesInform avatar Sep 04 '23 19:09 JamesInform

@JamesInform , this is make stop because anybody have never try to compile against PG16r1 ;-) Please add in https://github.com/pgspider/sqlite_fdw/blob/90dad0a3ae7b8ffd129149088e094276c439ed61/Makefile#L40 in your clone and ./test.sh How many tests will be failed? Maybe compilation will be impossible?

mkgrgis avatar Sep 05 '23 03:09 mkgrgis

@JamesInform , you should also copy tests from 15.0 to your version identify directory, see https://github.com/pgspider/sqlite_fdw#tests and my extended draft https://github.com/mkgrgis/sqlite_fdw/tree/readme-fix-and-additions#tests.

mkgrgis avatar Sep 05 '23 04:09 mkgrgis

Thanks. When I run ./test.sh I get:

image

Building throws an error:

image

JamesInform avatar Sep 05 '23 06:09 JamesInform

@JamesInform , what was the method of Pg source getting in you case? git? wget ... tar.gz? Something other? Have you tested make check of PostgreSQL sources itself? Please also refer my draft about testing environment https://github.com/mkgrgis/sqlite_fdw/blob/readme-fix-and-additions/TESTING.md

mkgrgis avatar Sep 05 '23 06:09 mkgrgis

Are you able to compile the source against PG16rc1?

JamesInform avatar Sep 06 '23 22:09 JamesInform

@JamesInform , I don't know about pgspider team, but I haven't tried to compile the source against PG16rc1. Anyway this need test file copying and analyse after resolving compilation problems if there are.

mkgrgis avatar Sep 07 '23 04:09 mkgrgis

Maybe you can try to compile. It seems you are more familiar with testing and error identification than me.

JamesInform avatar Sep 07 '23 20:09 JamesInform

It seems you are more familiar with testing and error identification than me.

I had have no testing experience at all some month before. In C projects usually somebody are welcome for questions and experiments. This is 2 sources of my testing experience. I have no experience to adopt some FDW to a new release.

mkgrgis avatar Sep 08 '23 05:09 mkgrgis

@JamesInform , We have been developing to support 16beta2 and will publish it by the end of this month.

t-kataym avatar Sep 12 '23 08:09 t-kataym

Great. Thanks for informing!

JamesInform avatar Sep 12 '23 20:09 JamesInform

@t-kataym v16 is due tomorrow. What is the status of the patch?

Regards, Devrim

devrimgunduz avatar Sep 13 '23 12:09 devrimgunduz

Almost is done for v16beta2. We are in progress to confirm on v16.0 and will release in the next week.

t-kataym avatar Sep 21 '23 07:09 t-kataym

We have just released new sqlite_fdw supporting PostgreSQL16.0.

t-kataym avatar Sep 27 '23 09:09 t-kataym

Thanks! I can confirm that it builds cleanly.

devrimgunduz avatar Sep 27 '23 09:09 devrimgunduz

@devrimgunduz , could you please also give some advices around of https://github.com/pgspider/sqlite_fdw/pull/80 ?

mkgrgis avatar Sep 28 '23 05:09 mkgrgis

@t-kataym I think this is solved and outdated issue after CI.yml using.

mkgrgis avatar May 22 '24 07:05 mkgrgis