node-supervisor icon indicating copy to clipboard operation
node-supervisor copied to clipboard

exit when child has exited, not earlier (mh)

Open binarykitchen opened this issue 11 years ago • 6 comments
trafficstars

With this little addition, the supervisor won't exit until the child process has really exited.

I need this feature because my app has a graceful shutdown.

Already tested it on my machine and works well. Also added few missing semicolons.

binarykitchen avatar May 30 '14 03:05 binarykitchen

What happens to your app without this feature?

iangreenleaf avatar Jun 10 '14 22:06 iangreenleaf

Without this, the graceful shutdown procedure is interrupted.

binarykitchen avatar Jun 10 '14 23:06 binarykitchen

+1 would like to see this merged as well. Right now support for graceful shutdown for the child is not present in process managers for node.js.

briandeheus avatar Jun 25 '14 10:06 briandeheus

+1 I have been looking for graceful shutdown support.

voltrue2 avatar Jun 25 '14 10:06 voltrue2

any news on graceful shutdown or workarrounds? this is a pain when combined with the file watcher and then having corrupt DB/Cache because my script is beheaded..

japrescott avatar Oct 09 '14 18:10 japrescott

Ok, I can see how this could be useful when some of the child processes take a moment to finish dying. Are those of you who've +1'd this using it on your systems? I'd like to hear from some folks who have tested this branch in daily use, to see if it works well in practice and if there are any ill side effects that commonly show up (for example, child processes hanging or not signalling their exit correctly).

iangreenleaf avatar Oct 12 '14 01:10 iangreenleaf