python-bitcoinlib icon indicating copy to clipboard operation
python-bitcoinlib copied to clipboard

Bignum handling is dodgy

Open petertodd opened this issue 11 years ago • 2 comments
trafficstars

Doesn't appear we handle bignums > 32bits correctly, and the code itself is uncommented, undocumented, and doesn't handle errors in any sane way.

petertodd avatar Oct 14 '14 14:10 petertodd

I might have misunderstood the purpose of this issue, but other than creating a dependency, is there a reason not to use ~~pyOpenSSL~~ pyca/cryptography as an interface to the various BN_* calls? (See my comment on #30.)

posita avatar May 02 '15 03:05 posita

@posita The BigNum handling doesn't need an external dependency, especially how that Bitcoin Core doesn't actually use it. What needs to be done is just a review/cleanup of the code itself; this issue is just to remind me I have something outstanding to fix!

petertodd avatar May 03 '15 22:05 petertodd