Peter Sutter
Peter Sutter
Also the os.Exit calls should be removed or at least reduced. See also this comment from @tedteng https://github.com/gardener/gardenctl/issues/328#issuecomment-734033925 Instead, like @andrei-panov wrote, the error should bubble up the call stack.
In addition: replace checks like len(target.Target) == integer with more descriptive getters Example: ```go if len(target.Target) == 2 { namespace = "garden" } else if len(target.Target) == 3 { namespace...
Hi @JensAc, please checkout this document https://github.com/gardener/dashboard/blob/master/docs/concepts/webterminals.md#browser-trusted-certificates-for-kube-apiservers The terminal feature requires a browser trusted certificate for the kube-apiserver (more details in the mentioned doc). In your terminal bootstrapping configuration you...
I see. Yes true, for the gardenlet `spec.secretRef` does not necessarily need to be set, however, as of now, it's required for the terminal feature. You would have to to...
@JensAc having the `spec.gardenlet.config.seedConfig.secretRef` set for `ManagedSeed`s is not really required, as @rfranzke pointed out in an out of thread communication. With the introduction of the `shoots/adminkubeconfig` endpoint we can...
> Just one other comment. The terminal feature should also work for the internal seed, right? So, this case should be handled differently, shouldn't it? what do you mean with...
Yes right, for all non-managed seeds the secretRef is still required on the `Seed` resource
/hold i need to check if the dashboard clusterrole needs to be adapted for the managedseed get permission as #1283 was merged meanwhile