humhub-basic-chat icon indicating copy to clipboard operation
humhub-basic-chat copied to clipboard

Emoji Support

Open Felli opened this issue 9 years ago • 12 comments

This is just something that I'm wanting (Planning) to be implemented into the Basic Chat module. So this can be used as a placeholder for now. :smile:

Options

Emoji One

Felli avatar Feb 16 '16 23:02 Felli

@Felli Yesterday I also experimented with it, unfortunately, it is harder to implement as it seemed. Have you already made some progress?

WebCrew avatar Feb 20 '16 21:02 WebCrew

I've honestly not had time recently, I hope to have a few hours tomorrow

On Sat, Feb 20, 2016 at 5:15 PM, WebCrew [email protected] wrote:

@Felli https://github.com/Felli Yesterday I also experimented with it, unfortunately, it is harder to implement as it seemed. Have you already made some progress?

— Reply to this email directly or view it on GitHub https://github.com/petersmithca/humhub-basic-chat/issues/9#issuecomment-186682939 .

petersmithca avatar Feb 20 '16 21:02 petersmithca

Yes no problem I understand, havve a nice evening Peter.

WebCrew avatar Feb 20 '16 21:02 WebCrew

My bad, I didnt notice the @Felli , git sent me an email and I just replied, lol! Have a good evening too

petersmithca avatar Feb 20 '16 21:02 petersmithca

Haha its ok Peter I`m happy You also took a look at it :)

WebCrew avatar Feb 20 '16 21:02 WebCrew

@WebCrew, @petersmithca, & @tobciu I was looking over this which gives a link here for some interesting oversight. :smile:

Felli avatar Feb 20 '16 21:02 Felli

ohhh nice thats maybe helpfull :smiling_imp:

I also thought about making use of this: [https://github.com/ritz078/embed.js]

WebCrew avatar Feb 20 '16 21:02 WebCrew

@WebCrew Look promising, I was looking over embedjs, but your option looks a lot better! :smiley:

Felli avatar Feb 20 '16 22:02 Felli

we will see :+1: Peter, Tobi and You have much more experiences with such things as I. So the decision is up to you mates lol

WebCrew avatar Feb 20 '16 23:02 WebCrew

So my thoughts on implementing emojis hasn't really changed much, I do like how @KaiserCoder has implemented emoji support into their version, the only problem I see with it is missing the svg images, so I'd like to do this somewhat like how HumHub has done with their emoji support, so I'll be working on a somewhat of a hack-ish way of implementing them then will do some tests.

As for #17 @petersmithca this needs looked over, but I'm 99% sure that it works, as for #16 I'm thinking maybe switching in Assets.php the chat_bright.css with chat_dark.css to see if this could fix the problem or if it happens the same way. :smile:

Felli avatar Apr 16 '16 23:04 Felli

I am thinking the css issue may be because its not loaded into the cache as its called dynamically until you switch templates. But I really am not sure how to fix and haven't had time for much of anything lately. I've merged the japanese language tho, thanks!

On Sat, Apr 16, 2016 at 8:57 PM, Sarah Tsumayoi [email protected] wrote:

So my thoughts on implementing emojis hasn't really changed much, I do like how @KaiserCoder https://github.com/KaiserCoder has implemented emoji support into their version, the only problem I see with it is missing the svg images, so I'd like to do this somewhat like how HumHub has done with their emoji support, so I'll be working on a somewhat of a hack-ish way of implementing them then will do some tests.

As for #17 https://github.com/petersmithca/humhub-basic-chat/pull/17 @petersmithca https://github.com/petersmithca this needs looked over, but I'm 99% sure that it works, as for #16 https://github.com/petersmithca/humhub-basic-chat/issues/16 I'm thinking maybe switching in Assets.php https://github.com/petersmithca/humhub-basic-chat/blob/dev/Assets.php#L11 the chat_bright.css with chat_dark.css to see if this could fix the problem or if it happens the same way. [image: :smile:]

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/petersmithca/humhub-basic-chat/issues/9#issuecomment-210925774

petersmithca avatar Apr 17 '16 09:04 petersmithca

Oh that was no problem I was glad to do that! I'm also planning on translating in Chinese as a lot of people that use my own site(s) are Chinese. As for this issue I'll continue looking into it as well as #16 no promises on any quick fixes tho. xD

Felli avatar Apr 17 '16 21:04 Felli