BigInteger.js icon indicating copy to clipboard operation
BigInteger.js copied to clipboard

Published 20 hours ago • verified publisher icon peterolson

Improve .toString(2) performance

Open Azero123 opened this issue 6 years ago • 5 comments
trafficstars

Azero123 avatar Apr 09 '19 07:04 Azero123

Coverage Status

Coverage increased (+0.006%) to 94.223% when pulling e631d629d0806040c7fb32b51ad01ae64d606adf on Azero123:master into 2e0619371f90aedb8e44cb3ab983b18a5ac699aa on peterolson:master.

coveralls avatar Apr 09 '19 07:04 coveralls

Coverage Status

Coverage increased (+0.006%) to 94.223% when pulling e631d629d0806040c7fb32b51ad01ae64d606adf on Azero123:master into 2e0619371f90aedb8e44cb3ab983b18a5ac699aa on peterolson:master.

coveralls avatar Apr 09 '19 07:04 coveralls

Coverage Status

Coverage increased (+0.006%) to 94.223% when pulling e631d629d0806040c7fb32b51ad01ae64d606adf on Azero123:master into 2e0619371f90aedb8e44cb3ab983b18a5ac699aa on peterolson:master.

coveralls avatar Apr 09 '19 07:04 coveralls

Coverage Status

Coverage increased (+0.006%) to 94.223% when pulling b22ebb65791daf02dda79d40862da3882fba0049 on Azero123:master into 2e0619371f90aedb8e44cb3ab983b18a5ac699aa on peterolson:master.

coveralls avatar Apr 09 '19 07:04 coveralls

Good point @Yaffle, that makes me realize that the alphabet argument isn't working for base 10 either. I should add more tests for the toString method with the alphabet argument

peterolson avatar Apr 11 '19 01:04 peterolson