galaxy_blast icon indicating copy to clipboard operation
galaxy_blast copied to clipboard

Merge BLAST XML tool

Open pvanheus opened this issue 7 years ago • 9 comments

As discussed on galaxyproject/tools-iuc#1893 this turns the merge code from the Galaxy BLAST XML datatype into a tool that can merge a list of datasets (or multiple individual datasets) into a single BLAST XML dataset.

pvanheus avatar May 22 '18 14:05 pvanheus

BTW this would be made obsolete by galaxyproject/galaxy#5464 if it was achieved.

pvanheus avatar May 22 '18 14:05 pvanheus

Assuming we later have blastxml2 defined as another datatype, is there anything you'd change now to allow this to merge multiple blastxml files OR multiple blastxml2 files? Or would that be a second tool?

(We would not want to try merging a mixture unless someone produces a robust script to interconvert from one format to the other).

peterjc avatar May 22 '18 14:05 peterjc

If blastxml2 is similar enough to be merged by the same tool, I think the simplest solution would be to make the format of the input and in the #for loop check that the inputs were consistent in the type being used (i.e. use a combination of #set, #if and $element.ext).

pvanheus avatar May 22 '18 14:05 pvanheus

If I read the Travis logs right the error isn't coming from this tool. Am I right?

pvanheus avatar May 22 '18 14:05 pvanheus

Grr. Another new TravisCI failure, but not your fault:

Applying linter tool_urls... FAIL
.. ERROR: Error '404 Client Error: Not Found for url: http://www.jcvi.org/cms/research/projects/tigrfams/overview/' accessing http://www.jcvi.org/cms/research/projects/tigrfams/overview/

Update: Cross reference https://github.com/peterjc/galaxy_blast/commit/d31e21d684a5dfa55dfb1a9aead744e2e7b87923 and https://twitter.com/pjacock/status/998941086168076288

peterjc avatar May 22 '18 14:05 peterjc

The error I am expecting to see is against the Galaxy master branch only, https://github.com/galaxyproject/galaxy/issues/6180

peterjc avatar May 22 '18 15:05 peterjc

@peterjc sadly the test against dev failed too - with errors I can't quite make out.

pvanheus avatar May 23 '18 20:05 pvanheus

Hmm. At the very least there were SQLite locking issues, which seems to be an intermittent problem. I've restarted that test on TravisCI, fingers crossed it gets further.

peterjc avatar May 24 '18 08:05 peterjc

The dev branch failed again on re-testing.

In good news, the yarn version issue problem has been fixed on the Galaxy master branch, so I've asked TravisCI to retest that.

peterjc avatar Jun 12 '18 11:06 peterjc