Peter Jaap Blaakmeer

Results 253 comments of Peter Jaap Blaakmeer

Curious to hear from more people having problems with this. We've been using this recipe for years and haven't run into this issue yet.

I think the problem lies here, from your comment; > not affected by umask cause it comes directly from git repository This folder shouldn't be in any git repository, since...

Ok you convinced me, sorry it took me a while to understand. Merged now!

I'm on the fence about this - we also do a split generation of the frontend and adminhtml but I feel like we're more an exception than the default. Since...

@vahonc we don't like using the GUI for adding blocks; 1. Less flexibility since we can only use what the editor gives us for options 2. The client might have...

@sdzhepa still curious to know how it is fixed in 2.4.4 then. Since the patch _can_ still be applied on 2.4.4, even though it is not meant for that version....

@nathanjosiah ok thanks for clearing that up. Just wanted to be sure the vuln was fixed in 2.4.4.

> Is there a work around to fix this issue ATM? Yes, see my OP

Bytheway, this issue is very similar to https://github.com/magento/magento2/issues/35479 but it concerns `magento/module-new-relic-reporting` and `magento/module-graph-ql` in that case.

You're right, it appears @sivaschenko refactored my PR but forgot to add the RemoveDuplicates file after extracting the logic. @sivaschenko do you still have that file somewhere?