Peter Jaap Blaakmeer

@frankdekker it would be great to also have notices for false positives. See my explanation here; https://github.com/123inkt/php-codesniffer-baseline/issues/7 PHPStan also does this, it's called "unmatched ignored errors", see https://phpstan.org/user-guide/baseline#generating-the-baseline @gsherwood what...

@BafS I wanted to give your solution a whirl, but I'm missing the `PhpEncoder` dep. Judging from the method signature, it's not https://github.com/Riimu/Kit-PHPEncoder?

@adamdbradley what's the status on this?

I've thought of this as well, but then for the `sales_order` table. Here's how I approached it: 1. Run `magerun2 db:dump --strip=@stripped --only-command` 2. Add `--ignore-table=sales_order` to the second command...

Patch for Magento 2.4.5-p1 to use with `vaimo/composer-patches`; ``` @package magento/module-tax @link https://github.com/magento/magento2/issues/35500 @level 0 diff --git Pricing/Render/Adjustment.php Pricing/Render/Adjustment.php index 0e5c619..06f4e02 100644 --- Pricing/Render/Adjustment.php +++ Pricing/Render/Adjustment.php @@ -185,6 +185,6 @@...

@kassner @hostep @simonmaass anyone aware of a workaround? We're running into this as well.

@norgeindian I haven't run in that yet, maybe because we generally use `mageplaza/module-smtp` to send mails with and we configure that to use some SMTP. Magento core now supports SMTP...

Go for it! :)

@nunomaduro @owenvoke do you have any guidelines on how to do better on the public api? Any suggestions?

@nunomaduro @owenvoke maybe it's an idea to merge this as long there is no better idea for a public api?