micropython-async icon indicating copy to clipboard operation
micropython-async copied to clipboard

Link/url broken #2

Open beyonlo opened this issue 4 years ago • 3 comments

Hi Peter!

In the link https://github.com/peterhinch/micropython-async/blob/master/v3/docs/I2C.md has a "The file sock_nonblock.py illustrates.." where "sock_nonblock.py" is a hyperlink to https://github.com/peterhinch/micropython-async/blob/master/v3/docs/sock_nonblock.py where this link do not exists.

Thank you.

beyonlo avatar Sep 23 '21 23:09 beyonlo

Sorry, I can't find this. I've searched I2C.md for "sock_nonblock" and also for "illustrates" and drawn a blank, both on the web and in my original text. Please could you point me to the error.

peterhinch avatar Sep 24 '21 08:09 peterhinch

Sorry, I pasted the wrong link.

The correct link is https://github.com/peterhinch/micropython-async/blob/master/v3/docs/TUTORIAL.md "The file sock_nonblock.py illustrates.." where "sock_nonblock.py" is a hyperlink to https://github.com/peterhinch/micropython-async/blob/master/v3/docs/sock_nonblock.py where this link do not exists.

beyonlo avatar Sep 24 '21 12:09 beyonlo

Thanks for the report.

This one isn't as easy to fix: the file sock_nonblock.py is in the V2 tree and I never ported it to V3. For the moment I've remove the reference while I decide whether to port that sample. I've also updated that section to reflect improvements to the firmware which have been implemented since the section was written.

peterhinch avatar Sep 24 '21 14:09 peterhinch

Closing. That code sample is out of date and I don't plan to port it.

peterhinch avatar Nov 25 '22 10:11 peterhinch