TwitterClient Add view for Friends

This adds a view to display your Twitter Friends (i.e. people you're following) along with their avatars. It is slightly more complicated than AccountsList or TweetsList as more API calls are needed (first get list of user ids, then request more info about those ids).

I also added a custom UIBarButtonItem icon for this view.

I hope you'll find this contribution helpful.

Also, I'm in the process of learning both Objective-C and the iOS SDK, so please don't hesitate to comment on anything that's not done efficiently or elegantly (e.g. data structures manipulation with NSArray and NSRange, UITableView handling, image caching, memory management, etc.).

May 31 '12 11:05 julien-c

Screenshot

May 31 '12 11:05 julien-c

@peterfriese Any chance you had a look at this? Thanks!

Jun 11 '12 09:06 julien-c

Hi Julien,

thanks for your contributions! I am quite busy ATM, but will look into them this week.

Cheers, Peter

On 11.06.2012, at 11:29, Julien Chaumond [email protected] wrote:

@peterfriese Any chance you had a look at this? Thanks!

Reply to this email directly or view it on GitHub: https://github.com/peterfriese/TwitterClient/pull/2#issuecomment-6240323

Jun 11 '12 11:06 peterfriese

Julien,

thanks again for your contribution!

I had a look at your code and as mentioned on Twitter already, I think there are a few performance issues. Also (and I believe this is more severe), we've got an API issue here. As you might know, the Twitter API is rate-limited and a given user is only permitted to perform a certain number of requests per hour. Yesterday, while testing your code, I ran into this limit.

As there are Twitter users with a serious amount of friends / followers, your code will quickly run into a situation where it will fetch enormous amounts of JSON and image data.

I therefore would like to suggest two things:

for the friends list, we should only load user details for the users that will be displayed on the current screen (maybe a few more to make scrolling a bit smoother).
while I do see the benefit of having a high-res picture, fetching the "bigger" profile picture incurs one additional API call which, if you do this for a lot of users will quickly lead to hitting the rate limit).

Please also take into consideration that this is a mobile application and not a desktop app, which means:

People don't always have a fast enough connection to download huge amounts of data
Users might also not be willing to pay for downloading all this data - not everybody is lucky enough to have a flat fee data plan.

I appreciate your contribution - if you could elaborate the above points, I'll have another look and consider it for merging.

Thanks! Peter

Jun 24 '12 15:06 peterfriese

Does this project will work with twitter API 1.1?