Peter Fox

Results 24 comments of Peter Fox

Funnily enough, this is something I've already looked into a little recently and PHPStan will soon be able to detect when this is happening so actually, we'd just need to...

I'm going to close this as @GeniJaho answer is right, there are not a lot of needs for this in what is essentially an upgrade rule. My suggestion would be...

@taylorotwell I did consider that It could just be an interface. The user might want to force that condition only in circumstances based on whether they felt it was risky...

I've only just seen this @GeniJaho 😓 my bad. I think adding the `pint.json` file made sense. Always happy to review though and add new rules.

@MrPunyapal currently it will ignore it. Do you know what the translation of that would be with the attribute? I forgot that was an option available

Okay cool. That should be simple enough to resolve 👍

@MrPunyapal I've now adapted for the scenario mentioned where the array's key might be the property.

Doesn't really matter if it's not deprecated. The rule is still useful for those who want to convert from Livewire 2 to 3 as it covers most of the scenarios....

Okay cool, so it's probably best to create the attributes with the parameters if set.

@MrPunyapal new version of the rule. Now covers transforming cases of 'as' and 'except' to be converted with the attributes into arguments.