Peter Dannemann
Peter Dannemann
Could we do something like this? We would need to do a bit of refactoring for handling kwargs but this should eliminate a lot more of our code ```python3 def...
Considering those changes would reduce the maintenance of the GCS module drastically I think it more than warrants a breaking change / major version bump. We could just redirect most...
> Hmm, so this has caused me a little more thinking than I was expecting and would be keen to get input on a few things > > 1. Testing!...
@mpenkov @piskvorky what is smart-open's stance on breaking API changes within the library? The opinion I have been expressing so far is that they are ok if we perform a...
Hi @Scrubi19, please provide a minimal reproducible code example. Please remove all of the unrelated code related to the web server you are running and provide something we can reproduce....
Hi @nicolaspeters, passing `Metadata` through CommitMessages seems challenging since [the function signature would have to change to support this](https://github.com/segmentio/kafka-go/blob/c293a8c49389ab9d9750532fbb81826c43fa25fc/consumergroup.go#L418). This sounds like a feature kafka-go should support- I think we...
Hi @cypriendker this seems like a good addition. Could you submit a PR adding this feature?
> @petedannemann @ssingudasu Hello, could you please review this PR? I need this functionality for my project, and unlike sarama and confluent, this library doesn't have it. Or at least...
> I've fixed everything with CircleCI except the linters; the error message on the linter is incomprehensible. If you'd prefer I can handle the Go version upgrade and linting fixes....
@zydovech this seems like a reasonable change but may be quite complex. Feel free to submit a PR with the fix if you have the time. If not a workaround...