DBD-mysql icon indicating copy to clipboard operation
DBD-mysql copied to clipboard

fix some queries with columns beginning with `limit` would fail

Open kebhr opened this issue 2 years ago • 1 comments
trafficstars

#288 fixes a problem in which SQL involving columns whose names end in limit cannot be generated successfully. However, this fix caused SQL containing columns starting with limit to fail to generate successfully (e.g. SELECT * FROM table WHERE limit_by > ?). This is because the syntax interpretation compares it to limit when it should be compared to limit which includes white space.

I have created a fix for this problem and a test code that can confirm this issue. With 4.050, modified t/35limit.t fails, but when this pull request is applied, it succeeds.

kebhr avatar Nov 23 '22 08:11 kebhr

@dveeden Hello. Could you please take a look at this pull-request when you have a moment?

kebhr avatar Aug 16 '24 10:08 kebhr

This seems ripe for merging - it has tests for the additional behaviour?

mohawk2 avatar Sep 18 '24 19:09 mohawk2