django-formidable
django-formidable copied to clipboard
[models] Rename Field.help_text → Field.description
Follow-up of #188
TODO
- [ ] Migration:
Field.help_text→Field.description - [ ] Migration:
Item.help_text→Item.description - [ ] Make sure that schema already serialized are still working1
Notes
- Maybe implement a mapping, and raise a python warning to tell developers that the field won't be available soon
I see that the schema migration mechanism is ready in the codebase but... I think there's something missing like:
- a way to easily run all the wanted migrations in order to upgrade the saved schemas from a version to the next one, and then eventually save them,
- a documentation on how to do it,
- integrate this migration mechanism in our internal (secret) projects, on-the-fly (would cost CPU, but would guarantee Blue/Green-like behaviour) or via a one-shot script (beware on how to keep it blue/green ?)
isn't this already done with the JSON migrations?
I think we should remove references such as: https://github.com/peopledoc/django-formidable/blob/e8f19dcaf10b22b4424b9e8a5903f1bd78fa7a33/formidable/serializers/fields.py#L78-L82
yes, and it's part of https://github.com/peopledoc/django-formidable/issues/292
my point was to say that the renaming has been completed, so I think we may close this one
I think this issue was about creating a Django migration, because currently, the attribute in the model is still help_text.
https://github.com/peopledoc/django-formidable/blob/e8f19dcaf10b22b4424b9e8a5903f1bd78fa7a33/formidable/models.py#L83
But if you think it will be addressed in #292, go ahead. 😉