react-native-gallery-manager icon indicating copy to clipboard operation
react-native-gallery-manager copied to clipboard

requiresMainQueueSetup warning

Open rangav opened this issue 7 years ago • 6 comments

Hi

Does it require main Queue or not? getting react native warning

+ (BOOL)requiresMainQueueSetup
{
    return YES;
}

rangav avatar Mar 10 '18 07:03 rangav

Hi @rangav ! When are you getting this warning?

pentarex avatar Mar 10 '18 17:03 pentarex

When you build the RN proj in xcode, you will see warnings in output

OR when remote js dubug enabled we will see in chrome console

rangav avatar Mar 11 '18 09:03 rangav

https://github.com/facebook/react-native/pull/17679 I guess it should return NO, The Image loader that this library is using is rewritten from RCTImageLoader (because I wanted to remove the dependencies). And somehow makes sense to be NO, because we don't want to block the app while loading the images. Anyhow its warning and its by default in the background.

I will fix it today and upload a new version, anyhow I have to add request authorisation to android :)

pentarex avatar Mar 11 '18 10:03 pentarex

Thanks @pentarex will change to NO and will do some testing.

rangav avatar Mar 11 '18 10:03 rangav

ok please let me know :)

pentarex avatar Mar 11 '18 11:03 pentarex

returning NO is working.

+ (BOOL)requiresMainQueueSetup
{
    return NO;
}

rangav avatar Mar 13 '18 06:03 rangav