Peng Liu
Peng Liu
We have these values cached in the style layer and source classes already, just for consistency we decided to go through the gl-native to get the latest property values, since...
Hi @LukasPaczos I tried to read through the ticket again, I think the bottleneck is the call of `getStyleLayerProperties` when you are using `style.getLayer(layerId)` API. The `getStyleLayerProperties` is pretty heavy...
@LukasPaczos thanks! I have triggered a snapshot, you can try `10.0.0-rc.1-peng-improve-getLayer-api-SNAPSHOT` when you have time.
@LukasPaczos I did some profiling on this change, in the same benchmark, the CPU utilisation seems to be improved Before(`getLayer` takes 12.1% CPU time, `getStyleLayerProperties` takes 8.7% CPU time): After(`getLayer`...
@LukasPaczos What's the code path to the `setStyleLayerProperties` call? I can try to look where we can optimise.
Setting the `lineGradient` and the under hood `setStyleLayerProperty` seems not avoidable on the platform side. @LukasPaczos could you suggest how I could simulate the navigation session with the gradient line...
The performance of `setStyleLayerProperty` with complex expressions seems to be the main bottle neck currently, we need to solve it by optimising the Value marshalling.
This could be related to https://github.com/mapbox/mapbox-maps-android/pull/455 @cafesilencio did you use Annotation plugin in that example(or under the hood in the navigation SDK)? cc @Chaoba
Hi @SamuelBrucksch thanks for reporting the issue, we are still trying to get access to a compatible Xiaomi device to reproduce this issue, will keep you posted about the progress.
@nstele Thanks for your feedback! I could not reproduce the issue locally with the current information. I have the following test code with `mapboxServicesVersion = '4.7.0' ` and the logs...