meteor-peerdb icon indicating copy to clipboard operation
meteor-peerdb copied to clipboard

Velocity causes warnings

Open Sivli-Embir opened this issue 11 years ago • 5 comments

After adding velocity I get: Error loading app files Reuse of a collection without replaceParent set Error: Reuse of a collection without replaceParent set. This is not really surprising given how velocity works. Any ideas on how to make PeerDB Velocity friendly?

Sivli-Embir avatar Sep 22 '14 15:09 Sivli-Embir

Do you know how Velocity works? :-) Care to explain? It seems like it is loading the same file multiple times?

Is there some hook which we could hook into to cleanup before next loading?

How does it address the issue that normal Meteor collections cannot be initialized multiple times? If you do new Meteor.Collection('foo') twice you will also get an error?

mitar avatar Sep 22 '14 21:09 mitar

I have a very vague idea but I am just starting to dive into it. I do know it is reloading the that app in a mirror copy of meteor. I will keep diving into it and see what I can see. Looking for how they deal with standard Collections is a good idea.

Mostly I just wanted to put it on your radar, as of yet I am only getting warnings and no errors. But I have not started writing tests involving PeerDB so we will see how long that lasts. If I can't find anything I will make an issue in Velocity core referencing this and see if they can help. Does that work with you?

Sivli-Embir avatar Sep 22 '14 21:09 Sivli-Embir

as of yet I am only getting warnings and no errors

Those warnings are like compilation time warnings. PeerDB is detecting that you are doing something wrong. And I must say that I have no idea what could go wrong for you if you do not address it. That codepath is completely untested and unsupported. Probably things will fall apart if you will want to do instanceof and similar things on documents from the database.

If I can't find anything I will make an issue in Velocity core referencing this and see if they can help. Does that work with you?

mitar avatar Sep 22 '14 21:09 mitar

I am postponing this in my app. Velocity just has to many issues to be usable right now.

Sivli-Embir avatar Sep 25 '14 11:09 Sivli-Embir

Is there anything new about this?

mitar avatar Jan 17 '15 07:01 mitar