peer-pad icon indicating copy to clipboard operation
peer-pad copied to clipboard

Run e2e tests on Jenkins

Open olizilla opened this issue 7 years ago • 6 comments

Peer pads e2e tests were being run on travis. We need to figure out how to get puppeteer working on Jenkins, now that the other CI systems have been disabled. Think this is totally doable, we just have't done it yet.

Please note, the tests are not currently being run in CI, as the Makefile is configured to only build the thing

https://github.com/ipfs-shipyard/peer-pad/blob/b93f2b0c301c26d585346ebcfb551f69caba8933/Makefile

olizilla avatar Jul 20 '18 11:07 olizilla

Is something missing from my side? I think it should work without any further work except including the test run in the Makefile

victorb avatar Jul 20 '18 13:07 victorb

I will get a PR together with the test steps in the Makefile to see if we need anything else

jacobheun avatar Jul 20 '18 15:07 jacobheun

the missing piece of the puzzle is an example of getting a test that uses puppeteer to run on Jenkins... We've got https://github.com/ipfs-shipyard/ipfs-webui/pull/728 which runs the webui puppeteer tests but they are currently timing out, and it's not clear why yet.

olizilla avatar Jul 20 '18 15:07 olizilla

It looks like we're missing some packages:

https://github.com/GoogleChrome/puppeteer/issues/1857 https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md

Here's the failing build I have going on jenkins: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%20Shipyard%2Fpeer-pad/detail/fix%2Fci/1/pipeline

jacobheun avatar Jul 20 '18 16:07 jacobheun

@jimpick would you take this one?

pgte avatar Oct 27 '18 11:10 pgte

I got similar puppeteet tests running on circle-ci which uses docker, and needed a bunch of deps installed for them to work. You can grab the list from there https://github.com/ipfs-shipyard/ipfs-webui/blob/e4ba1d8d8f67f52444a1c806b5a043aae6b1ed7a/.circleci/config.yml

Of note, we're keeping things simple on the webui project and just using travis for the CI tests including e2e as we're also using it for bundlesize warnings https://github.com/siddharthkp/bundlesize#2-build-status and using jenkins for the publish to ipfs and update dnslink

olizilla avatar Oct 29 '18 14:10 olizilla