Pedro Pedreira

Fixed in https://github.com/facebookincubator/velox/pull/9862

Support for this was already added. We should be good to close this one.

Hi @hn5092 thank you for starting this discussion. I'm curious about how much faster this gets if you compare to our current merge join implementation. If I understood it correctly,...

That makes sense to me. We had planned to fix this as part of the vectorized merge join effort, but somehow in the pipelines we were testing, key comparisons did...

My understanding is that merge join is heavily used in Spark though. Cc: @FelixYBW is that the case?

> How do we apply the results of comparing two vectors to a merge join? I understand that in the end it resembles a hash join model, except that the...

Thanks guys

Hi @pramodsatya, not sure if I'm following. Why can't you just serialize the results of the expression (which are probably encoded as constant vectors) as PrestoPage using this API? It...

@pramodsatya thank you for clarifying. Could we instead provide an option in PrestoOptions to make the serializer skip the header instead? I think what I'm slightly concerned is moving VectorStream...

@mbasmanova @assignUser @majetideepak @czentgr addressed review comments. Please take another look when you have a moment.