feat: default `github_token` to `github.token`

[MichaelDeBoey]

Fixes #309

[peaceiris]

Thank you for the work. This pull-request fixes #309

[codecov[bot]]

Codecov Report

Merging #624 (4509111) into main (2c9f853) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #624   +/-   ##
=======================================
  Coverage   61.73%   61.73%           
=======================================
  Files           4        4           
  Lines         277      277           
  Branches       49       49           
=======================================
  Hits          171      171           
  Misses        105      105           
  Partials        1        1           

Impacted Files	Coverage Δ
src/set-tokens.ts	43.24% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2c9f853...4509111. Read the comment docs.

[MichaelDeBoey]

@peaceiris I think this one can be merged?

[peaceiris]

I have added #309 to the v4 milestone. Since it takes a long time to publish, I will investigate this first from the viewpoint of backward compatibility, then try to merge this into the v3 line. 👍

[MichaelDeBoey]

@peaceiris this PR is backwards compatible, as the action now defaults to github.token when it's not provided. If people provide it themselves, it will still work.

[peaceiris]

this PR is backwards compatible, as the action now defaults to github.token when it's not provided. If people provide it themselves, it will still work.

Not enough. We need to consider the source code. Perhaps, 631dd15 enables backward compatibility.

[privatenumber]

I understand this change is not backwards compatible because of the case where users are using personal_token instead of github_token (so this is empty).

AFAIK, using a PAT or GITHUB_TOKEN is interchangeable (just different permissions).

Would it be possible to eventually consolidate these two inputs into a token that defaults to github.token?

[georgettica]

Could we promote this? I saw some code and the GitHub token sws non required. Would be glad to help here if I can (as it seems straightforward)