soundbounce-v2 icon indicating copy to clipboard operation
soundbounce-v2 copied to clipboard

Clientside validation removal made the server crash

Open Paralectic opened this issue 7 years ago • 5 comments

After some testing and doing some client side validation remvoingI managed to post way too big messages to the server which made it all go down.

Please add some kind of server side validation before attempting to process it.

Paralectic avatar Jan 29 '18 10:01 Paralectic

Note: If you try loading the room with long messages the entire server crashes for approx 15 minutes. This issue needs to be fixed asap.

th0mk avatar Jan 29 '18 12:01 th0mk

That 'approx 15 minutes' is actually me on my server unpicking the corrupt data and restarting the service...

Thanks for the info but please can you stop trying to deliberately break our hosted copy of soundbounce. If you want to do this kind of penetration testing can I suggest you spin up your own local copy so it's not kicking us all off and causing me extra work on my day off ;)

pdaddyo avatar Jan 29 '18 12:01 pdaddyo

Actually I am very pleased with Soundbounce and the functionality it supports, I was just kind of curious how it would handle these requests, not meant to disturb any services. If you need any help anytime hit me up.

Paralectic avatar Jan 29 '18 14:01 Paralectic

Sorry, I only opened the room once and after i realized it crashed the server I didn't open it again. The room is still on the frontpage, so other people might have opened it. I didn't expect my messages to crash the entire server- sorry for causing you extra work on your day off.

th0mk avatar Jan 29 '18 14:01 th0mk

No probs and thanks for the interest! If you want to get involved (fixing stuff, adding features) please do - shout if you want a hand getting the local environment set up.

pdaddyo avatar Feb 06 '18 07:02 pdaddyo