jupyterlab-sql icon indicating copy to clipboard operation
jupyterlab-sql copied to clipboard

Possibility of users changable settings?

Open mcclaassen opened this issue 6 years ago • 5 comments

This link describes the process by which a user can change extension settings.

I could not find a settings file referring to this extension (something of the form<package_name>/<extension_name>.jupyterlab-settings). While a file can be created by the user I am unsure which settings would be alterable.

Are there any settings currently alterable?

mcclaassen avatar Nov 14 '19 01:11 mcclaassen

Thanks for raising this here, and apologies for the late reply.

Are there any settings currently alterable?

No, there are not. What settings do you think you would want to set?

pbugnion avatar Dec 28 '19 15:12 pbugnion

Hi there. The most desired for me would be:

  • changing the relative size of the code window and table window (e.g. make either window take up the whole screen while using it)
  • make the table window dark themed

Otherwise, awesome extension! Thanks for the reply.

mcclaassen avatar Dec 30 '19 16:12 mcclaassen

Hi @mcclaassen ,

Thanks for the feedback!

It feels to me like:

changing the relative size of the code window and table window (e.g. make either window take up the whole screen while using it)

This would be best served by being able to resize the two sections, rather than hard-coding a setting somewhere?

make the table window dark themed

jupyterlab-sql should just respect the current theme.

What do you think?

pbugnion avatar Jan 02 '20 07:01 pbugnion

I agree with

This would be best served by being able to resize the two sections, rather than hard-coding a setting somewhere?

Typical mouse based window resizing functionality would be great.

As for

jupyterlab-sql should just respect the current theme

The coding-window does respect the theme but (for me) the table-window (where the query results are displayed) is still white. With the black theme of the coding-window (and the inability to reduce the table-window), this can be quite glaring.

Cheers!

mcclaassen avatar Jan 02 '20 16:01 mcclaassen

Thanks for clarifying.

pbugnion avatar Jan 06 '20 07:01 pbugnion