json-schema-validator icon indicating copy to clipboard operation
json-schema-validator copied to clipboard

Published 20 hours ago • verified publisher icon pboettch

Could you add some BUILD.bazel files to support bazel build?

Open HiaWinter opened this issue 2 years ago • 7 comments

My project using bazel to build and I want to import your project, if you think it's ok to add some BUILD.bazel files in your project, I can raise a PR to support it, thanks.

HiaWinter avatar May 12 '23 09:05 HiaWinter

As long as the main build is going through cmake it should be fine. Can discuss more about the design in the PR since it is faster to weed out the details with an example.

LecrisUT avatar May 16 '23 10:05 LecrisUT

Oh, I think we should just change it back for people using the library without CMake after building. There are some I guess. Could you take care of it, @LecrisUT - as you are the who broke it :-P .

pboettch avatar May 16 '23 11:05 pboettch

Sure, I'll make a hotfix in a minute. Let's open an issue to plan some renamings. Target names will become unmanagable otherwise.

LecrisUT avatar May 16 '23 11:05 LecrisUT

@pboettch Sorrry, we got the wrong issue here. This is the bazel issue not the soname one

LecrisUT avatar May 16 '23 11:05 LecrisUT

Not we. It's only me. Doing 5 things at the same time....

pboettch avatar May 16 '23 11:05 pboettch

Also to blame because I marked it with Fixes in the PR :grin:

LecrisUT avatar May 16 '23 11:05 LecrisUT

HiaWinter, are you able to suggest a PR for integrating Bazel-support?

pboettch avatar Nov 27 '23 09:11 pboettch