react-url-query icon indicating copy to clipboard operation
react-url-query copied to clipboard

ComponentWIllMount Deprecated

Open ghost opened this issue 6 years ago • 1 comments

Do you want to request a feature or report a bug? A potential bug

What is the current behavior? It might break in the future

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar. N/A

What is the expected behavior? Should be compliant with the upcoming react update.

Which versions of react-url-query, and which browser and OS are affected by this issue? Did this work in previous versions of react-url-query? N/A

Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: RouterToUrlQueryLogic, SideEffect(NullComponent)

ghost avatar Oct 11 '19 08:10 ghost

Upvote

Please at the very least release a patch version with the method renamed to UNSAFE_...

Roeefl avatar Feb 13 '20 09:02 Roeefl