libwdi icon indicating copy to clipboard operation
libwdi copied to clipboard

install_driver_internal UAC elevation does not work correctly

Open PyroAVR opened this issue 2 years ago • 1 comments

I noticed that while deploying libwdi inside a custom application (not using the Zadig frontend), the UAC elevation logic does not correctly detect if the user is an administrator already. This leads to failed installation due to missing privileges.

Inverting the result of IsUserAnAdmin in install_driver_internal seems to fix the issue.

PyroAVR avatar Sep 15 '23 17:09 PyroAVR

Relevant PR is #300.

Thanks for submitting this. This indeed looks like an error in the code, and I'll apply the PR when I get a chance...

pbatard avatar Jan 05 '24 15:01 pbatard

Fixed in bd17edc3e23d1c7c67dbf78daecc7d3012cae048.

pbatard avatar Jun 13 '24 13:06 pbatard