Pete Batard

That's a GRUB upstream issue. Their declaration is not consistent with the actual function definition. I suggest you send a patch to GRUB upstream, as it will naturally find its...

Impressive work! I will need some time to review it, so it won't be part of the upcoming 4.7 release, but I'll see what I can to to include it...

Thanks for keeping the PR up to date. Considering that there are already a lot of major changes for 4.8, and that I am heaving towards an "early" release of...

Hmm, I'm not seeing that issue at all, be it with the release binaries I am compiling or the Actions build ones. I tested on 3 different physical Windows 11...

@ozone10, I'm working on integrating this patch at long last, but it seems to me like the subclassed `WM_NCDESTROY` messages are not being processed, which results in memory leaks. Note...

Aha! Looks like it all boils down to the main proc of Rufus calling `EndDialog()` rather than `DestroyWindow()` at: https://github.com/pbatard/rufus/blob/9a32dba290d3b4eacda54bbccb38fa5b2b9ccdba/src/rufus.c#L2326 None of the `WM_DESTROY`/`WM_NCDESTROY` (including the ones we have in...

Yeah, at any rate, [the documentation for `CreateDialogIndirect()`](https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-createdialogindirecta) (which is what we use to create the main dialog) explicitly states: > To destroy the dialog box, use the [DestroyWindow](https://learn.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-destroywindow) function....

After some reformatting (to make it look more harmonized with the rest of the code) I think I'm good with the PR, so I am going to push the commit...

@jensanjo, you built wdi-simple without the WinUSB driver, and wdi-simple will try to install that driver by default. If you want to use libusb-win32, you need to pass the option...

Thanks for the report. At this stage, I am not sure if I'm ever going to try to fix that, as this isn't going to affect a lot of people....