payload icon indicating copy to clipboard operation
payload copied to clipboard

chore: ensure node 22 version is 22.8 or above

Open tyteen4a03 opened this issue 1 year ago • 1 comments

An important UTF-8 bug was discovered in v22.7 and fixed in v22.8. We should only allow v22.8 to avoid this issue for end users such as https://discord.com/channels/967097582721572934/1311108065218662491.

Also updates Node version used by various CI tooling to be compliant with the new setting

tyteen4a03 avatar Nov 26 '24 23:11 tyteen4a03

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

socket-security[bot] avatar Nov 26 '24 23:11 socket-security[bot]

Thanks for opening this @tyteen4a03. However, I don't think this is the responsibility of Payload to enforce versions based upon bugs in Node.js.

Also depending on how strict you want to be, this technically would also be a breaking change for anyone earlier Node 22 versions that are supported.

denolfe avatar Dec 30 '24 20:12 denolfe

Thanks for opening this @tyteen4a03. However, I don't think this is the responsibility of Payload to enforce versions based upon bugs in Node.js.

Also depending on how strict you want to be, this technically would also be a breaking change for anyone earlier Node 22 versions that are supported.

In that case, what's the point of having Node.js version constraints at all?

tyteen4a03 avatar Dec 30 '24 21:12 tyteen4a03

Thanks for opening this @tyteen4a03. However, I don't think this is the responsibility of Payload to enforce versions based upon bugs in Node.js. Also depending on how strict you want to be, this technically would also be a breaking change for anyone earlier Node 22 versions that are supported.

In that case, what's the point of having Node.js version constraints at all?

The version constraints are specifically because Payload utilizes Node.js features only available in those versions.

denolfe avatar Dec 30 '24 21:12 denolfe