yaspin icon indicating copy to clipboard operation
yaspin copied to clipboard

feat: truncation with custom ellipsis

Open sdaqo opened this issue 1 year ago • 2 comments

This addresses #131 by truncating the text and adding the ability to set an custom ellipsis.

sdaqo avatar Jul 11 '24 00:07 sdaqo

@pavdmyt Sorry for the bump, would like to know if there is still anything to do here.

sdaqo avatar Aug 23 '24 00:08 sdaqo

Also, there should be an entry about ellipsis argument in yaspin/api.py (in the docstring for the yaspin function).

pavdmyt avatar Aug 23 '24 09:08 pavdmyt

Alright, this should address everything, let me know if I left something out!

sdaqo avatar Sep 13 '24 21:09 sdaqo

CI lint step fails with:

ERROR: /home/runner/work/yaspin/yaspin/tests/test_ellipsis.py Imports are incorrectly sorted and/or formatted.
make: *** [Makefile:31: check-fmt] Error 1
Error: Process completed with exit code 2.

You can run make check-fmt to check formatting for your changes and make isort, make fmt to properly format your changes.

pavdmyt avatar Sep 14 '24 13:09 pavdmyt

Wait I will clean up the lint errors...

sdaqo avatar Sep 14 '24 13:09 sdaqo

ok, fixed and squashed

sdaqo avatar Sep 15 '24 12:09 sdaqo

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.88%. Comparing base (a8569be) to head (d9acaae). Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
yaspin/core.py 90.47% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   95.20%   94.88%   -0.32%     
==========================================
  Files           5        5              
  Lines         375      391      +16     
==========================================
+ Hits          357      371      +14     
- Misses         18       20       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 15 '24 12:09 codecov-commenter

@sdaqo Thanks for your contribution 👍🏼 This PR will be included in the next yaspin release.

pavdmyt avatar Sep 16 '24 07:09 pavdmyt