servoshell icon indicating copy to clipboard operation
servoshell copied to clipboard

.im is not considered a TLD

Open metajack opened this issue 8 years ago • 4 comments

Typing "metajack.im" into the url bar takes me to duckduckgo instead of to the url. I'm guessing the TLD detection needs a bit of expansion.

metajack avatar Sep 19 '17 16:09 metajack

relevant code: https://github.com/paulrouget/servoshell/blob/2235fb865cdecbefbb4ee108750411399b38ce8a/src/main.rs#L233

paulrouget avatar Sep 19 '17 18:09 paulrouget

We should use servo::net_traits::is_pub_domain.

paulrouget avatar Sep 19 '17 18:09 paulrouget

We should use servo::net_traits::is_pub_domain.

I agree - trying to properly handle TLDs in the embedding is a losing game - they're just too complex and require large-ish tables and such.

tschneidereit avatar Sep 19 '17 20:09 tschneidereit

I'm confused, is_pub_domain seems to allow more that what resources/pub_domain.txt is listing.

paulrouget avatar Sep 20 '17 03:09 paulrouget