Paul Cleary

Results 117 comments of Paul Cleary

This is definitely something that should no longer exist. Easy enough fix as it impacts tests only, but we really should NEVER use `await` anywhere including tests.

This is some low hanging fruit, I recommend we investigate this and bump it in our priority list.

Definitely building out some example applications beyond the simple Spring MVC would be great

I think this makes sense. Adding methods to the API are good. I wonder if money can directly implement any open-telemetry API / interface(s) as well? In other words, abandon...

Yes, @petercline The commit says "omicron committed on Aug 29, 2017" I wonder if that is where it is getting confused. The commit author is different than "petercline"

There is support for a "normal" http client. Have you reviewed that? What we did there was have a "TraceFriendlyHttpClient" that wrapped all calls to http client and would inject...

Thanks for this! Will review this week. Looks like travis is unhappy, so should fix that first.

@HaloFour circling back to this. I am readying a 0.9.0 release. Is this something that is still needed?

@HaloFour no worries on this PR, I was just asking if it was something that you guys specifically used. If not, we can add it after the 0.9.0 release in...

I think we cross compile. I think for the newest version (master) we remove support for EOL'd stuff. We may have to support Java 7 still, we can cross compile...