Paul Fitzpatrick
Paul Fitzpatrick
> Edit: would it be acceptable for you a PR which removes the GRIST_DISCARD_REDIS_CHECKSUM_MISMATCH env variable btw and which discards the redis checksum in all the cases? This is acceptable,...
The test failure looks relevant: ``` (1) DocApi should work directly with a docworker Webhooks /webhooks endpoint should call to a webhook only when columns updated are in watchedColIds if...
> Should the raw WebSocket backend remain available? In theory, Engine.IO will upgrade to the more efficient transport (i.e. WebSockets over long polling) and therefore it would seem unnecessary to...
> The Fly deployment failure seems caused by the fact that PRs based on branches from forks do not have access to repository secrets, for obvious security reasons. You may...
(just did a quick test in firefox with `network.websocket.max-connections` set to 0 and working perfectly so far with no websockets, very nice)
I just updated the preview at https://grist-http-long-polling.fly.dev/ and edited a doc using firefox with `network.websocket.max-connections=0` on `about:config`. Worked fine! Checked fly.io backend logs and confirmed that I see `transport=polling` in...
Thanks @jonathanperret and @dsagal ! This is really great to have. One thing that came to my mind recently as possible follow-up. @jonathanperret is it possible to determine whether long-polling...
> @paulfitz I see what you mean. I'm not optimistic however that a Grist administrator would notice such a warning, particularly since it wouldn't occur right on server startup. I...
Hmm sorry about that. This might be where the restriction is set? https://github.com/gristlabs/grist-core/blob/af38519ce39cec8dc4565095e5e30d9168043893/app/client/components/ChartView.ts#L422-L431 I see there is a TODO to clean it up :)
The sync of grist-saas code @georgegevoian mentioned happened this morning. The relevant change I think is this one: https://github.com/gristlabs/grist-core/commit/c6fd79ac1f08ab4146e3bca400325052b4ad257e Maybe @georgegevoian can give more context. Sorry for how opaque this...