patternfly-react icon indicating copy to clipboard operation
patternfly-react copied to clipboard

Published 20 hours ago • verified publisher icon patternfly

chore(Popover) convert examples to TypeScript

Open Dominik-Petrik opened this issue 3 years ago • 3 comments

What: Closes #7751

Dominik-Petrik avatar Jul 28 '22 14:07 Dominik-Petrik

Preview: https://patternfly-react-pr-7770.surge.sh

A11y report: https://patternfly-react-pr-7770-a11y.surge.sh

patternfly-build avatar Jul 28 '22 14:07 patternfly-build

It looks like the build is failing because you have an extra " before an isBeta flag on one of your examples? either that or it's unable to parse the isBeta before the file name.

nicolethoen avatar Jul 29 '22 12:07 nicolethoen

It looks like the build is failing because you have an extra " before an isBeta flag on one of your examples? either that or it's unable to parse the isBeta before the file name.

Seems like there is missing " on L61, the isBeta flag before filename shouldn't cause any problems. Although it is better to follow this syntax: ts file='<<filename>>' isBeta

tompsota avatar Aug 01 '22 12:08 tompsota