fix(MenuToggle): fix indeterminate checkbox error, toggle click behavior

[kmcfaul]

trafficstars

What: Closes #10034 and #10035

For 10034 - checked needed to use the result of calculateChecked instead of just the isChecked prop (because null needs to be re-resolved to false to prevent the issue).

For 10035 - This one is a little tricky, because the new toggle structure was not set up to wrap or pass the toggle click handler to the splitButtonItems. I've opted to put the onClick on the outer div wrapper, and prevent propagation in the splitButtonItems (on the action button and checkbox input specifically), but we may want to consider which behavior we want. We can use the changes in the PR currently (the whole div becomes clickable), or make the checkbox label text click trigger the checkbox input change handler instead (keeping the toggle button as the only toggle click handler), or let a user pass the onClick manually to the MenuToggleCheckbox.

[patternfly-build]

Preview: https://patternfly-react-pr-10066.surge.sh

A11y report: https://patternfly-react-pr-10066-a11y.surge.sh

[kmcfaul]

@mattnolting

[kmcfaul]

Per working session conversation, I'm adjusting the click changes to not use a click event on the outer div (which doesn't really make sense and would cause some accessibility issues). Now, clicking the text should check/uncheck the checkbox, as is the usual behavior for checkboxes with labels. Toggling can only be done with the toggle button for splitButtonAction toggles because the behavior is divided between two interactive elements.

[patternfly-build]

Your changes have been released in:

• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• [email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]
• @patternfly/[email protected]

Thanks for your contribution! :tada: