patternfly-react-demo-app

patternfly-react-demo-app copied to clipboard

Overview submenu doesn't appear on hover or click

4

The markup implies that there should be two links under Overview: Projects, Stages. But neither hover nor click will reveal these items (gif below): ```html Overview Overview Projects Stages ```...

benjaminapetersen

It sounds obvious but you need to perform that at step 0 before to run the getting started steps. Or at least in some environments a npm install might not...

lucasponce

Update README.md to encourage yarn instead of npm?

2

I believe the community is leaning towards yarn now, but curious if the patternfly react crew has a pref.

benjaminapetersen

Contemplating this as an idea, but seems like, since its waiting for the component to load, a loading spinner could be in order here.

benjaminapetersen

Noticed that [react-router doesn't handle query strings as of v4](https://github.com/ReactTraining/react-router/issues/4410), but guessing there is a favored way among users for making up for this deficiency. If so, perhaps add a...

benjaminapetersen

Add Redux Tests

3

* add tests for Redux reducers / stateless components, etc.

priley86

Console error about `activeHref` prop

1


benjaminapetersen

* Currently Prettier plugin has [issues](https://github.com/prettier/prettier-eslint/issues/92) respecting `tslint` configuration. However, as long as `prettier.singleQuote` is enabled in your IDE, it should be fine to use Prettier and avoid tslint errors....

priley86

* Once the React Bootstrap's [NavDropdown](https://react-bootstrap.github.io/components.html#navs-dropdown) is implemented in PF-React [#42](https://github.com/patternfly/patternfly-react/issues/42), let's add a logout mechanism which clears the logout cookie via Redux.

priley86