patternfly-org icon indicating copy to clipboard operation
patternfly-org copied to clipboard

Use long form text variation

Open srambach opened this issue 1 year ago • 1 comments
trafficstars

A users has noted that overall, the text size in PatternFly has decreased. This is in line with an overall adjustment to font sizing coming from the larger design community. https://github.com/patternfly/patternfly/issues/6830 gives details and some a11y concerns were addressed in https://github.com/patternfly/patternfly/pull/6846, which introduces rem units to allow text resizing.

We have identified that there are tokens intended for a larger long-form text, but the large size is currently not used outside the text-size utility class.

We need to determine if the org site should adjust itself to use the larger text token or use a utility class; if the content component should be modified to use the larger text for body text, or if a large variant of body text should be created.

srambach avatar Aug 01 '24 19:08 srambach

After discussion between @srambach @mcoker and @lboehling -

There is a long term goal to differentiate type sets for functional components, vs editoral text vs expressive elements like a big page banner.

There is a short term goal to increase the font size on the long form text on .org.

There are a couple of options to accomplish the short term goal -

  1. Just make the change on .org with a modifier for the content component in the org code
  2. Make the font adjustment a basic part of the content component

For now, let's do this:

  1. Add a modifier to increase default/small font sizes (.pf-m-editorial or something like that)
  2. Make this work also for text that isn’t in a content block - this example

This can be a spike for core, see if it’s feasible to get in for v6 final release and added as a beta enhancement to content component. If it’s too much to squeeze in to v6 final, we can just make these changes on org and plan to push it upstream to the content component after the v6 release

srambach avatar Aug 05 '24 18:08 srambach