patternfly-org icon indicating copy to clipboard operation
patternfly-org copied to clipboard

Update multiple guidelines to reflect new usage of labels and label groups as chips

Open mmenestr opened this issue 2 years ago • 2 comments
trafficstars

Get rid of chips guidelines, and write new guidelines for labels as chips.

Design issue here: https://github.com/patternfly/patternfly-design/issues/1222

Background: We have decided to fully deprecate chips in favor of labels, which will cause the following changes:

  • Getting rid of the chip and chip group components
  • Creation a new compact label group component (will want to document this)
  • Change the standard label group component to match the new compact label group styling (will want to update images for this)
  • Update all Filter demos and table demos that include chips in them (will want to update images in Filters to match)
  • Update Multiple select component to include labels instead of chips inside the toggle (will want to update pictures of this in guidelines too)

All relevant details and mocks can be found here: https://www.sketch.com/s/d7e287f4-39e3-4c17-a302-2131d8f3ea87

mmenestr avatar Feb 15 '23 14:02 mmenestr

This is on hold pending completion of https://github.com/patternfly/patternfly/issues/5344 which has been moved to the post-V5 backlog. In the interim we want to just merge the documentation for Chip and Chip Group so they appear on the same page. Opened #3480 to track that work.

mcarrano avatar Apr 10 '23 17:04 mcarrano

@edonehoo - this seems to be something that is going to happen for PF6. In the staging, chips now have more of a label styling, but I guess we'll have to see exactly how we want to communicate this change in the guidelines. Leaving it on hold for now. Also created a PF6 design guidelines label to flag that this applies to the future state of PF!

mmenestr avatar May 06 '24 15:05 mmenestr

This will move towards completion as images are updated as part of a few of these https://github.com/patternfly/patternfly-org/issues/4235 (I'll update here when that one has moved more)

edonehoo avatar Oct 04 '24 20:10 edonehoo