"Download failed"

[FoxP]

Hello,

When downloading certain files, it fails. Config :

• pCloud encrypted remote
• latest stable (also beta) rcloneExplorer
• wifi or LTE

How to reproduce : https://youtu.be/7HSPYBYToOs

[patrykcoding]

Does the download fail for the same files every time, or does it appear to be random? Also, do the same files download fine on desktop using rclone?

[FoxP]

It fails for the same files every time, and i can download them on desktop using rclone or Rclone Browser. Can i generate a log file or something to help you ?

Directory structure to access the file: (maybe because the path is long or has special chars?)

[patrykcoding]

I tried replicating this bug by creating a file structure identical to yours but my download finished without any problems.

The newest beta (1.6.0-016-22156fb-β) seems to have broken logging for downloads, so I'm attaching a special release that restores the logging. The apk is based on download-failed-bug branch (for transparency). Please download one of the APKs, enable logging (settings > under miscellaneous > use logs). Then try to download one of the files that fails. Once the download fails, you can attach the log file here (or just copy and paste the output). The log file will be located under Android/data/ca.pkay.rcexplorer/files/logs/log.txt

RcloneExplorer.apk RcloneExplorer-x86.apk RcloneExplorer-ARM32.apk RcloneExplorer-ARM64.apk

[FoxP]

Here is the log file: log.txt

[patrykcoding]

Thanks. Unfortunately I'm having some problems understanding the error. From the log file I can see that the error is chtimes: operation not permitted. When I Google for that error, some of the results are for rclone. So right now I'm not sure if the error is caused by a bug in rclone, or a bug in rcloneExplorer. I created another version that runs rclone copy with -vv flag (in hindsight I should probably make that a default when logging is enabled). This should help me determine if the problem is caused by rclone or not. Could you please install the new APK, enable logging if you have disabled it, download the file that fails, and attach the new log file. Afterwards you can update to the latest stable or beta release if you prefer.

Also, could you check if the file is actually downloaded despite the failed notification?

Thanks.

RcloneExplorer.apk RcloneExplorer-x86.apk RcloneExplorer-ARM32.apk RcloneExplorer-ARM64.apk

[FoxP]

No problem, here is the new log file from your debug branch: log.txt

I also checked / compared (with local) the hash of the downloaded file to see if it is corrupted, but it seems that it was perfectly downloaded despite the failed notification:

If i try to download the same file from Windows, here is the log content (no error):

2018/08/05 08:18:57 INFO  :
Transferred:      0 Bytes (0 Bytes/s)
Errors:                 0
Checks:                 0
Transferred:            0
Elapsed time:        6.6s
Transferring:
* Instructions.pdf

2018/08/05 08:18:58 INFO  : Instructions.pdf: Copied (new)
2018/08/05 08:18:58 INFO  :
Transferred:   77.309 kBytes (10.306 kBytes/s)
Errors:                 0
Checks:                 0
Transferred:            1
Elapsed time:        7.5s

I also tried with a bigger file (2Go), but i had a different behavior: i had an infinite download loop, i clicked "cancel" on the download notification, then i had the "download failed" message again. After a hash check, the downloaded file was similar to my local file. It seems that the "download progress" notification is not reliable enough.

What i have found on Google:

• https://forum.rclone.org/t/couldnt-parse-date/4753
• https://github.com/ncw/rclone/issues/1582
• https://github.com/ncw/rclone/issues/738
• https://github.com/ncw/rclone/issues/1195

[FoxP]

:bulb: Idea : A fix could be to implement the rclone check (doc) and rclone cryptcheck (doc) commands and perform a check after download if enabled from settings?

[patrykcoding]

Thanks for all the information. I'm starting to think that this issue is directly related to rclone and not rclone explorer. Which makes me think that you might be better off opening an issue on the rclone github page or their forum.

Rclone Explorer runs an rclone command (like rclone copy), and lets rclone do its thing. Once the rclone command finishes, rclone explorer just grabs the exit status and displays the appropriate notification. Also, the chtimes error is an error from Go which is also rclone related. From the logs it seems that rclone explorer gives rclone all the correct information.

I definitely think that the root of the problem should be fixed, instead of just ignoring it and having a hacky way of checking if file download succeeded. When rclone detects an error, it tries to download the file again, up to three times. This means that if you're downloading a 10 Mb file, you're now using 30 Mb because rclone tries to download it three times despite the fact that it succeeded on the first run.

I'm curious if you had this problem only on v1.6.0 (stable and betas) or on previous versions too.

[FoxP]

Ok, i have opened an issue on rclone github page: https://github.com/ncw/rclone/issues/2446

I tried 1.60, 1.50 and 1.40 (all stable), same issue.

[EDIT] Ok, it's a rclone bug. We need your help on this: https://github.com/ncw/rclone/issues/2446#issuecomment-410680606 [EDIT2] If i open a file by clicking on it, it works, it will be opened without error (picture, video, pdf, ...). If i click on "download", i have the "Download failed" notification message.