rcloneExplorer icon indicating copy to clipboard operation
rcloneExplorer copied to clipboard

See downloads/transfers

Open drejjmit opened this issue 7 years ago • 12 comments
trafficstars

The ability to see what's downloading and time left / transfer speed?

drejjmit avatar Jul 01 '18 11:07 drejjmit

Ability to see time left and transfer speed is unfortunately not possible. Once the rclone binary is run, as far as I know, it's not possible to retrieve any information until after the command finishes.

Ability to see what's downloading is a great idea though.

patrykcoding avatar Jul 10 '18 05:07 patrykcoding

RcloneBrowser that uses rclone is able to show progress. https://github.com/mmozeiko/RcloneBrowser Perhaps you can check the code or talk with coders... Also check https://github.com/ncw/rclone/issues/2347 TIA

caspertone2003 avatar Jul 20 '18 02:07 caspertone2003

@caspertone2003 I'm fully aware about Rclone Browser, however Rclone Browser is written in C++ and is for Windows/MacOS/Linux while Rclone Explorer is written in Java for Android. They're not compatible.

As far as I'm aware, once I run Runtime.getRuntime().exec(command) I'm not able to retrieve any output until after the command finishes. This means that while the download/upload command is running, I can't retrieve any progress (like Rclone Browser does).

Now if someone knows any way to work around this, I would gladly implement download/implement progress reporting.

patrykcoding avatar Jul 21 '18 18:07 patrykcoding

Just tried to help... no offense please. I am just unable to even code hello world in visual basic ... :-( Thanks for your tool! CT

caspertone2003 avatar Jul 21 '18 19:07 caspertone2003

@caspertone2003 Sorry, didn't mean to sound so hostile. The lack of any progress during downloads and uploads is one of the few aspects about the app I'm dissatisfied about and I am trying to figure out a way to improve that. Thanks for your input though :smiley:

patrykcoding avatar Jul 22 '18 00:07 patrykcoding

@kaczmarkiewiczp you were not hostile... as for your reply I noticed that my comment must have sound arrogant.

By the way, would it be possible at least to know when each transfer completes? By file or by batch... A small tick or change of colour besides the file. Either up or downwards transfers...

For example, how I know that something that I set to transfer box->cloud finished and I can delete it localy? It could happen that someone just unplugged the box at the middle of the transfer....

On the other hand, another question. An interrupted up/down load, is it re-tried?

Thanks again

caspertone2003 avatar Jul 22 '18 09:07 caspertone2003

@caspertone2003 This issue is about ability to see downloads and uploads. I'm envisioning a screen where all the transfers are shown with status information (in progress, complete, failed). So you would be able to see what has finished, and what failed to download/upload.

Currently there is detailed notification for downloads that shows what is downloading, and notification for failed and completed downloads. For uploads, however, there is a very basic notification. I'll need to refactor this so that there's also a more detailed notification for uploads.

Now about interrupted transfers; the app itself doesn't do any retries, but rclone does. As far as I'm aware, rclone will re-try transfers if connectivity is interrupted.

patrykcoding avatar Jul 24 '18 20:07 patrykcoding

Just an update on this, I managed to figure out how to display transfer progress. The same information that is displayed by rclone and rclone browser is now displayed for all transfers in notification. It was first added in #194 and then improved in #198.

I overlooked the fact that rclone sends progress output to stderr instead of stdout. After that it was easy to figure out how to retrieve the output while rclone is running.

This feature is available in the latest beta and will be available in the next stable release.

patrykcoding avatar Aug 05 '18 07:08 patrykcoding

On latest beta i found some issues:

  • the download notification (when folded / small) shound display transfer progress like 13% or 1Go / 12 Go
  • it downloads each file 3 times then fails (related to https://github.com/kaczmarkiewiczp/rcloneExplorer/issues/192 ?)
  • log file is empty
  • file is ok / not corrupted despite the "fail" notification

Video : https://youtu.be/R68Gb7tqTEs

FoxP avatar Aug 05 '18 10:08 FoxP

@FoxP Thanks for the feedback.

The notification layout was designed the way it is after some considerations on how rclone works. First of all, the notification displays the stats in the same order as rclone. Also, when downloading folders, rclone shows progress for the file being currently downloaded from the folder, and not the whole folder. That's why in the collapsed form, it's the "transferred" stat that is shown. Rclone doesn't provide information like 1Gb/12Gb. Rclone Explorer only displays the information that rclone provides, and in an order that makes the most sense.

I'm aware that logging doesn't work right now. It's just that when I'm grabbing output for the notification, I can't grab any errors later in the logging function since they were consumed by the notification. I'll try to have this fixed in the next beta, and definitely before the stable is released.

It sounds like the "failed notification" issue is related to #192. Is it the same files showing a failed notification like in #192, or do all files fail now on this beta?

patrykcoding avatar Aug 06 '18 08:08 patrykcoding

Thanks for your answer.

All files seems to fail on beta, and stable the same way.

FoxP avatar Aug 06 '18 09:08 FoxP

@kaczmarkiewiczp Thanks for including this feature! I will try it with next stable. CT

caspertone2003 avatar Aug 18 '18 00:08 caspertone2003