Patryk Bojczuk

Results 5 comments of Patryk Bojczuk

> This is quite dated You're right, I didn't notice that I was so behind, however in this case nothing has changed after the upgrade. I'll update the MikroORM version...

I’ve found an issue with the `OddTableNames.mysql.test.ts`. Previously, in the `E123TableName` entity, there was a nonexistent `Table$39s$32name$32has$32apostrophe$44$32also$32$96$32this` entity used (it’s part of another database) as a `prototype` property type, but...

> Same way as if the name was a completely typical name that doesn't need any escapes... @boenrobot It could be different name (it just happened to be odd in...

@boenrobot Yes, I think it will be better if addressed in the future PR, perhaps by someone with more experience in mysql/mariadb realm.

> you've [indirectly](https://app.codecov.io/gh/mikro-orm/mikro-orm/pull/6138/indirect-changes) caused loss of coverage in [MsSqlQueryBuilder's getKnexQuery() when using it for truncate type queries](https://app.codecov.io/gh/mikro-orm/mikro-orm/pull/6138/blob/packages/mssql/src/MsSqlQueryBuilder.ts#L26) (like... how?) It's probably because truncate is not tested anywhere, whereas earlier, for...