Patrick Pircher

Results 151 comments of Patrick Pircher

fix vite dep optimizer

> > I suggest to create a link from @embroider/rewritten-packages to the one inside > > This is how things used to work. Doing it correctly requires more than just...

fix vite dep optimizer

fixed in #2135

vite also needs to resolve index.{gjs,gts}

one test failed while fetching node...

vite also needs to resolve index.{gjs,gts}

somehow after adding the extensions to resolve. the module-resolver resolveComponent is receiving `type: ignore` results...

vite also needs to resolve index.{gjs,gts}

the commit https://github.com/embroider-build/embroider/pull/1826/commits/5559000f31fe6dc330ee17dcc0794fab5847da73 makes esbuild resolver behave the same as vite, when we have a `not-found` we report it as external. now another issue: all imports that are resolved via...

vite also needs to resolve index.{gjs,gts}

I think for virtual files we want to add a suffix instead of a prefix. It should then be able to generate correct imports that use the dep optimization

vite also needs to resolve index.{gjs,gts}

2 issues: * resolveWithinMovedPackage changes importer to be in node-modules, which makes vite/esbuild ignore it. 1. solution: generate links to rewritten-packages that are resolvable via node resolution and just rewrite...

vite also needs to resolve index.{gjs,gts}

vite also needs to resolve index.{gjs,gts}

will be fixed by #2029

improve addon-dev clean

> so one thing that I would like to do before we actually move forward on this is that we verify that this Plugin works correctly with the bug scenario...