hash-graph icon indicating copy to clipboard operation
hash-graph copied to clipboard

Edge arguments

Open nobrakal opened this issue 7 years ago • 3 comments

Hi,

I want to benchmark hash-graph for the 2018 Google Summer of Code and I need to construct edges with Edge.

data Edge a b = Edge !b !a !b deriving (Eq, Generic, Show)

What is the purpose of the mid-term of type a ? Is it for labeled-graphs ? I saw you use it for the Ord instance, and your use of it in the benchmark suite is obscure to me...

nobrakal avatar Apr 25 '18 16:04 nobrakal

Yes, it is for labels. You can do Edge () b if you don't want labels though.

I think the examples folder is a little better than my documentation at the moment unfortunately :/ This one should be a little clearer: https://github.com/patrickdoc/hash-graph/blob/master/examples/Basic.hs.

This project isn't in the best state, but if you need anything from me, let me know! Good luck with your project; I'm interested to see the results!

patrickdoc avatar Apr 25 '18 17:04 patrickdoc

Thank for the response, you are right, examples are clear.

As I will need to read and understand the code, I think I can help to document if you want!

Ps: This project is already at a good state :)

nobrakal avatar Apr 25 '18 18:04 nobrakal

I would definitely welcome critiques/info about what is unclear or hard to use. I think it is going to change a bit soon? When I tested the water on reddit people brought up some valid problems. I'm rethinking the design a bit to accommodate different use cases.

But a big part of the reason I started this was about usability, so feel free to dump ideas here about what you find good/not good.

patrickdoc avatar Apr 25 '18 18:04 patrickdoc