oauth2-apple icon indicating copy to clipboard operation
oauth2-apple copied to clipboard

Published 20 hours ago • verified publisher icon patrickbussmann

Update Apple.php

Open ibimsdeandy opened this issue 2 years ago • 2 comments
trafficstars

The method is declared as public in GenericProvider and any other provider and throws an error if it is protected. If we use this plugin together with bigfork/silverstripe-oauth it works only if the method is public.

ibimsdeandy avatar Jul 18 '23 06:07 ibimsdeandy

getDefaultScopes() is declared as "protected" in league/oauth2-client/src/Provider/AbstractProvider.php, You should not override methode visibility. Maybe you should open an issue in "league/oauth2-client", so they could fix this mismatch.

magicsunday avatar Oct 11 '23 14:10 magicsunday

@ibimsdeandy thank you for your work but tests failing. Please check and then I'll merge. 👍

patrickbussmann avatar Oct 13 '23 11:10 patrickbussmann