Patrick Allaert

Results 29 comments of Patrick Allaert
trafficstars

> @patrickallaert you see any possible BC breaks here? I haven't seen any BC break. +1 from me, especially since we are at the beginning of the cycle of next...

Just one remark from me: this PR is mixing code change and CS fixes. If I'm all for fixing CS issues, I rather prefer keeping things separated as it makes...

+1, provided that you rebase (fixup) your commit into one commit and ensure you have "Fix EZP-16913: cronjobs/workflow.php..." in the title.

Not sure it counts, but well :-) +1!

@crevillo AFAIR, the best practice used was (maybe undocumented) not to use the trailing `?>` but also, not trying to changes all files "at once" but only changing the files...

@andrerom Do you mean I should rather reverse that change?

This whole block is to define a `$view_dir` variable that isn't used anymore. `$renderMode` and `$renderData` variables are only used to create `$view_dir`.