vscode-advanced-new-file icon indicating copy to clipboard operation
vscode-advanced-new-file copied to clipboard

Published 20 hours ago • verified publisher icon patbenatar

Ignore symbolic links when loading directories

Open matthewmcgarvey opened this issue 3 years ago • 3 comments

Fixes #74

The only difference between statSync and lstatSync is that the latter handles symbolic links while the former causes an error. Then we can ignore symbolic links.

https://nodejs.org/api/fs.html#fslstatpath-options-callback

matthewmcgarvey avatar Dec 10 '21 20:12 matthewmcgarvey

Confirming this changes resolved my issue as well! Would love to get this merged in :)

devo-wm avatar Jan 07 '22 13:01 devo-wm

@matthewmcgarvey Thanks for the fix! Sorry for my delay in getting to this -- I don't have much time to support this plugin these days. I've gone ahead and given you push access to this repo if you're interested in helping maintain it.

It'd be great if we could add test coverage for this change. I started down that path but realized I haven't run the development environment for this project in a long time and looks like things have changed wrt how VS Code extensions are tested (https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode).

patbenatar avatar Jan 08 '22 18:01 patbenatar

@patbenatar Appreciate it! I'll try to figure out the testing thing

matthewmcgarvey avatar Jan 08 '22 18:01 matthewmcgarvey